MC-3441

Luci dispatching this ticket to Larry (background worker via SSH).

Larry: Planning — reading ticket and target filePROGRESS: Building — adding temperature range validationPROGRESS: Testing — running typecheckPre-existing errors unrelated to my change. Let me confirm.Pre-existing errors confirmed unrelated. Now checking branch state.PROGRESS: Building — committing changePROGRESS: Done — pushing branchPROGRESS: Done — temperature validation added and pushed on feat/mc-3441

Completed on Larry: Added range validation (0–2, finite number) for the `temperature` override in `POST /api/documents/:id/analyze` at `server/routes/documents.ts:396`, returning HTTP 400 on invalid input. This matches the existing user-settings constraint and prevents extreme values from reaching AI API calls. Committed as `cf535ad` on `feat/mc-3441` and pushed to origin.

Larry: Triggering post-completion code review...

Code review (Larry reviewer via claude/opus): Valid ates temperature override on /analyze with proper type, fin iteness, and range checks before use. MINOR: server/routes/documents.ts:396 — validation runs before the try/catch, so thrown errors here would bypass route error handling. Not an issue in practice since the checks are pure comparisons that can't throw, but placing validation inside the try block would be more consistent with the rest of the handler. MINOR: server/routes/documents.ts:404 — error message says "between 0 and 2" which is accurate but doesn't clarify the range is inclusive; minor wording nit. VERDICT : PASS Validates temperature override on /analyze with proper type, finiteness, and range checks before use. MINOR: server/routes/documents.ts:396 — validation runs before the try/catch, so thrown errors here would bypass route error handling. Not an issue in practice since the checks are pure comparisons that can't throw, but placing validation inside the try block would be more consistent with the rest of the handler. MINOR: server/routes/documents.ts:404 — error message says "between 0 and 2" which is accurate but doesn't clarify the range is inclusive; minor wording nit. VERDICT: PASS

Larry shipped with clean code review. Auto-dispatching Luci-reviewer (verdict: clean). Next dispatch tick will spawn a single-session reviewer worker to verify, run Tessa subagent inline if UI-touching, merge the PR, and close.

Completed: DONE: Larry's temperature validation fix (commit `cf535ad8`) for `POST /api/documents/:id/analyze` verified — adds type check, `Number.isFinite`, and 0–2 range validation matching the existing `userSettings` constraint. Code review passed clean. Cherry-picked onto staging as `6315771b`, pushed to origin. Ticket MC-3443 marked done.