MC-3580 — [SafairBru] get_cache_key() is dead code with misleading timestamp logic

Home Board MC-3580

[SafairBru] get_cache_key() is dead code with misleading timestamp logic

get_cache_key (line 3717) generates cache keys with minute-rounded timestamps, but is never called anywhere. The actual caching infrastructure (get_cached_data/set_cached_data) ...

State Done Next Action Closed Owner Luci Runtime Closed Age 27d ago

Description

MC-3580

get_cache_key (line 3717) generates cache keys with minute-rounded timestamps, but is never called anywhere. The actual caching infrastructure (get_cached_data/set_cached_data) uses simple string keys with manual TTL checks. If someone later uses this function expecting correct caching behavior, the time-bucketed keys would cause stale reads (same key for a whole minute regardless of TTL) and cache misses on minute boundaries. File: app.py:3717 Complexity: simple Found by: nightly code review (f2ecd69 fix(MC-3260): use _sast_now() in health endpoint timestamp) Auto-fix skipped: Luci-side scheduled autofix is disabled by default; Larry owns SafairBru code changes.

Activity

done

Luci is working...

Details — Done · Low · Luci ▼

State

Done

Closed

State

Priority

People

Owner (assigned to)

Controller

Timing / Details

Due Date

Snooze

Source safairbru-review (scheduled)

Project SafairBru

Created 27d ago

Updated 27d ago

Advanced / Operator evidence

Routing owner

Routes via

Operator console

Evidence

Ticket is done; runtime is closed. completed profile claude_opus_1m_medium · cwd /home/lucienne/workspace · uptime 27d 3h · last activity 27d 1h ago MC is visibility-only. Hermes Luci launches and gates work outside MC, then mirrors evidence/status here. b691e1e8-e3f4-451c-9953-4e3f754833e4 · luci · claude/anthropic/opus[1m]

Workflow

Start Dev Review + QA ▾

Select phases to include:

Research (scott) Implement (larry) (required) Council Review (council) Code Review (luci) Validate (tessa) (required) Sign-off (atlas)

Agents

Review Gates

Decision

WAT routing: choose an agent, review gate, or decision. Buttons use the live runtime when one is attached.

luci 27d ago

Luci dispatching this ticket to Larry (background worker via SSH).

luci 27d ago

Larry: Planning — reading ticket and codebase context

luci 27d ago

Larry: Building — removing dead function get_cache_keyPROGRESS: Testing — verifying app.py still compilesPROGRESS: Done — removed dead get_cache_key() function and updated CLAUDE.md section map

luci 27d ago

Completed on Larry: Tier 1 classification: delete dead function `get_cache_key` at app.py:3717.Confirmed `get_cache_key` is only defined, never called. Removing it. Removed the unused `get_cache_key()` function from app.py:3717 and dropped its reference from the CLAUDE.md section map. Verified no callers existed via grep, and confirmed app.py still parses. Committed as 6f41d03.

luci 27d ago

Larry: Triggering post-completion code review...

luci 27d ago

Code review (Larry reviewer via claude/opus): D ead code removal of unused `get_cache_key()` function; no callers, saf e deletion. VERDICT: PASS Dead code removal of unused `get_cache_key()` function; no callers, safe deletion. VERDICT: PASS

luci 27d ago

Larry shipped with clean code review. Auto-dispatching Luci-reviewer (verdict: clean). Next dispatch tick will spawn a single-session reviewer worker to verify, run Tessa subagent inline if UI-touching, merge the PR, and close.

luci 27d ago

Completed: DONE: Verified Larry's MC-3580 fix on SafairBru host (`~/cowork/projects/safairbru`). Commit `fb5e948` removed dead `get_cache_key()` (7 lines, app.py:3717) plus its CLAUDE.md section-map reference. Confirmed zero callers via grep, `app.py` compiles clean, and commit is already pushed to origin. Tier 1 dead-code deletion — clean, no regressions, closing.