You're offline — showing cached data

MC-4516

P0: Make WAT action audit atomic (use add_comment_with_controller_audit)
2026-06-13 08:46:45 SAST
Home Board MC-4516

P0: Make WAT action audit atomic (use add_comment_with_controller_audit)

WAT dispatch actions (app.py lines ~12032-12068) use models.add_comment followed by a separate dispatch_controller_event call. If the server crashes between them, the audit exis...
State Done Next Action Closed Owner Luci Runtime Closed Age 12d ago
MC-4516
Ticket is done; runtime is closed.

Description

MC-4516
WAT dispatch actions (app.py lines ~12032-12068) use models.add_comment followed by a separate dispatch_controller_event call. If the server crashes between them, the audit exists but the Controller never receives the event. Human comments use add_comment_with_controller_audit which is atomic. WAT actions should use the same pattern. Acceptance Criteria: - [ ] WAT action uses add_comment_with_controller_audit (or equivalent atomic path) - [ ] Hook only fires on atomic success - [ ] Hook failure still does not fail the original request - [ ] Tests prove atomicity Files: app.py (WAT action handler, lines ~12020-12080), tests/test_control_room_event_hooks.py Evidence: Council review finding (2026-06-01): Codex reviewer flagged as P0.

Activity

done
Luci is working...
Live
No activity yet
Help