P2: Add test coverage for system-comment bypass when v2 NOTIFY is ON
No tests exist for system/agent comments posted to /api/v1/tickets/42/comments when _controller_notify_enabled() is True. This gap allowed the legacy bypass to go undetected. A...
StateDoneNext ActionClosedOwnerLuciRuntimeClosedAge12d ago
No tests exist for system/agent comments posted to /api/v1/tickets/42/comments when _controller_notify_enabled() is True. This gap allowed the legacy bypass to go undetected.
Acceptance Criteria:
- [ ] Test proves system comment does NOT trigger _queue_and_pickup when NOTIFY=ON
- [ ] Test proves system comment does NOT mutate status when NOTIFY=ON
- [ ] Test proves legacy path still works when NOTIFY=OFF
Files: tests/test_control_room_event_hooks.py
Evidence: Council review finding (2026-06-01): Kimi reviewer flagged as test gap.
Activity
done
INTERACTIVE
Luci is working...
Details —
Done
· Medium
· Luci
▼
SState
Done
Closed
PPeople
TTiming / Details▼
luci (human)
Mission Control
12d ago
12d ago
Advanced / Operator evidence
RRouting owner
ROperator console
Ticket is done; runtime is closed.MC is visibility-only. Hermes Luci launches and gates work outside MC, then mirrors evidence/status here.
WWorkflow
Start Dev Review + QA ▾
Select phases to include:
Agents
Review Gates
Decision
WAT routing: choose an agent, review gate, or decision. Buttons use the live runtime when one is attached.
Controller gate: verified implementation landed on master in commit 37f1ab2; Control Room v2 regression suite passed (180 passed). Closing stale needs_input row left by headless worker retirement.