MC-4719 — Port mc_ticket.py input hardening from rejected MC-4655 duplicate f21105

Home Board MC-4719

Port mc_ticket.py input hardening from rejected MC-4655 duplicate f21105

Follow-up from MC-4709. Route to Luci when convenient; optional, not urgent. The MC-4655 fix landed via branch 918c22 commit 5ed940a6 and is done. Its duplicate-dispatch sibling...

State Done Next Action Closed Owner Luci Runtime Closed Age 9d ago

Description

MC-4719

Follow-up from MC-4709. Route to Luci when convenient; optional, not urgent. The MC-4655 fix landed via branch 918c22 commit 5ed940a6 and is done. Its duplicate-dispatch sibling f21105 commit f025aa37 was discarded in the MC-4709 sweep because it was built on a stale base and would revert about 18k lines if merged. f21105 carried extra input hardening worth porting as a fresh surgical patch onto current origin master mc_ticket.py: reject non-regular files such as symlink, FIFO, dir, device; cap input at 256 KiB; reject empty or whitespace-only comment bodies; and catch non-UTF-8 decode errors so a bad file exits cleanly instead of a traceback. Not required to fix MC-4655. See docs/solutions/mc-4709-recover-merge-sweep.md.

Activity

done

Luci is working...

Details — Done · Low · Luci ▼

State

Done

Closed

State

Priority

People

Owner (assigned to)

Controller

Timing / Details

Due Date

Snooze

Source api (human)

Project Mission Control

Created 9d ago

Updated 6d ago

Advanced / Operator evidence

Routing owner

Routes via

Operator console

Evidence

Ticket is done; runtime is closed. ticket_runtime_done profile claude_opus_1m_medium · cwd /home/lucienne/workspace/mission-control/.claude/worktrees/pool-1 · uptime 8d 10h · last activity 8d 8h ago MC is visibility-only. Hermes Luci launches and gates work outside MC, then mirrors evidence/status here. Raw console: luci · claude/anthropic/opus[1m]

Workflow

Start Dev Review + QA ▾

Select phases to include:

Research (scott) Implement (larry) (required) Council Review (council) Code Review (luci) Validate (tessa) (required) Sign-off (atlas)

Agents

Review Gates

Decision

WAT routing: choose an agent, review gate, or decision. Buttons use the live runtime when one is attached.

elmar 8d ago

@luci can you check if still required

Luci 8d ago

Ported f21105 input hardening to mc_ticket.py _resolve_text — reject non-regular files (symlink/FIFO/dir/device), cap 256KiB, catch non-UTF-8 cleanly, reject empty/whitespace comment bodies. Smoke-tested all 4 paths + happy path. Committed+pushed workspace master 9ba4de8b.

luci 8d ago

Workflow action `review_ready` applied. Work ready for review.

api 6d ago

Controller gate: verified no Elmar decision is needed. Claimed workspace commit 9ba4de8b is present and an ancestor of origin/master (conrelma/luci-workspace); changed file is mc_ticket.py. Basic CLI smoke passed (mc_ticket.py --help and comment --help). Closing as done. Note: stale done_sha metadata pointed at unrelated 5df56170; closure evidence is verified 9ba4de8b on origin/master.

Controller decision