MC-4341 — Fix shadow-review runner stale import path

Home Board MC-4341

Fix shadow-review runner stale import path

Make the shadow-review runner use current Mission Control modules, not stale mc-orchestrator-build-mc code. Verify exact scheduled module paths and focused tests. Do not restart...

State Done Next Action Closed Owner Luci Runtime Closed Age 16d ago

Description

MC-4341

Make the shadow-review runner use current Mission Control modules, not stale mc-orchestrator-build-mc code. Verify exact scheduled module paths and focused tests. Do not restart the dashboard or delete stale folders.

Activity

done

Luci is working...

Details — Done · High · Luci ▼

State

Done

Closed

State

Priority

People

Owner (assigned to)

Controller

Timing / Details

Due Date

Snooze

Source api (human)

Project Mission Control

Created 16d ago

Updated 16d ago

Advanced / Operator evidence

Routing owner

Routes via

Operator console

Evidence

Ticket is done; runtime is closed. ticket_runtime_done profile claude_opus_1m_medium · cwd /home/lucienne/workspace/mission-control · uptime 16d 6h · last activity 16d 3h ago MC is visibility-only. Hermes Luci launches and gates work outside MC, then mirrors evidence/status here. Raw console: luci · claude/anthropic/opus[1m]

Workflow

Child phase of MC-4340

MC-4341 · luci done MC-4342 · luci done MC-4343 · luci done MC-4344 · luci done

Agents

Review Gates

Decision

WAT routing is active. Agent/review buttons inject the next step into the live runtime or dispatch a fresh worker.

lucienne 16d ago

Controller sequencing: released first to Luci. Fix runner imports and prove scheduled module paths before downstream work moves.

Controller decision

Luci 16d ago

Shadow-review runner now imports current mission-control modules (was stale mc-orchestrator-build-mc); scheduled command runs clean, 39 focused tests pass, committed+pushed 393eb955.

luci 16d ago

Workflow action `complete` applied. Work completed.

luci 16d ago

Shadow reviewer verdict: FAIL (cycle 1/3). Reopening for fixes. Reasons: The ticket MC-4341 requires fixing the shadow-review runner's stale import path from mc-orchestrator-build-mc to current Mission Control modules, verifying scheduled module paths, and running focused tests. However, the committed diff exclusively modifies app.py to implement per-chat runtime sessions (MC-4327) and makes no changes to any shadow-review runner, scheduled command, or test files. The worker's evidence claims 39 focused tests pass and references a different commit hash (393eb955) than the diff source (860f326c), suggesting the diff provided does not match the claimed work. The dirty_tree=1 flag also indicates uncommitted changes exist. Gaps: - No changes to shadow-review runner import paths in the diff - No verification of scheduled module paths - No test files added or modified in the diff - Commit hash mismatch between evidence (393eb955) and diff source (860f326c) - Diff appears to implement MC-4327 (per-chat runtime sessions) rather than MC-4341 (shadow-review runner fix) - dirty_tree=1 indicates incomplete commit state

api 16d ago

Operator verification: fix already shipped in commit 393eb955 (run_shadow_reviews.py inserts live /home/lucienne/workspace/mission-control path; 39 focused tests passed). Current code verified: imports mc_orchestrator_flags + mc_shadow_review from the live path, ZERO stale mc-orchestrator-build-mc references in scripts/ or mission-control/. Scheduled task runs clean (shadow-review.log shows reviewed/reconciled, no import errors). The 04:09 shadow-reviewer FAIL was a false negative — verdict text shows it fetched the WRONG diff (an MC-4327 app.py per-chat-runtime change, not 393eb955): the known slot-branch diff-fetch failure (mem 5937). Closing done.