MC-4497 — Reviewer/Council preflight — Control Room v2 behavior-change baseline

Description

MC-4497

Reviewer/Council preflight for MC-4494 before behavior-changing Control Room v2 implementation. Objective: Establish the current baseline for WAT/workflow actions, ticket comments, inline dispatch, runtime start/resume, board labels/status, Telegram routing, and pickup behavior before we modify them. Scope: - Read-only audit first. Do not edit code in this ticket. - Identify exactly where current code auto-spawns or resumes runtimes from comments/workflow actions. - Identify current Workbench/WAT buttons and how they map to Larry/Tessa/Council/Luci/review actions. - Identify current board/status/label representation and any existing metadata mechanisms we can reuse. - Identify tests that should protect the next behavior-changing slices. - Produce a concise council/reviewer handoff: approved implementation path, risks, required tests, and rollback/feature-flag strategy. Acceptance criteria: - Baseline report/comment names concrete files/functions/routes. - Confirms which changes are safe as Phase 2/3/4 and which need feature flags. - Confirms comment-added path will become notify-controller, not auto-dispatch. - Preserves runtime guidance as advisory and Controller choice as authoritative. - No code changes in this preflight ticket. Expected check-in: 2026-05-31 16:51:19 UTC.

Activity

done

Luci is working...

Details — Done · High · Luci ▼

State

Done

Closed

State

Priority

People

Owner (assigned to)

Controller

Timing / Details

Due Date

Snooze

Source telegram (human)

Project Mission Control

Created 13d ago

Updated 13d ago

Advanced / Operator evidence

Routing owner

Routes via

Operator console

Evidence

Ticket is done; runtime is closed. ticket_marked_done profile claude_opus_1m_medium · cwd /home/lucienne/workspace/mission-control · uptime 12d 19h · last activity 12d 16h ago MC is visibility-only. Hermes Luci launches and gates work outside MC, then mirrors evidence/status here. 803fe995-dfe3-46ed-beb0-2edd2373790f · luci · claude/anthropic/opus[1m]

Workflow

Child phase of MC-4494

MC-4495 · luci done MC-4496 · luci done MC-4497 · luci done MC-4499 · luci done MC-4500 · luci done

Agents

Review Gates

Decision

WAT routing is active. Agent/review buttons inject the next step into the live runtime or dispatch a fresh worker.

controller 13d ago

Preflight opened. Read-only reviewer/council baseline before changing WAT/comment/dispatch behavior.

reviewer-council 13d ago

Reviewer/Council preflight completed. Role: Reviewer/Council Runtime/capability: Hermes delegate_task read-only audit Scope: Baseline current WAT/workflow actions, comment-triggered dispatch, runtime start/resume, board/status/labels, Telegram routing, and pickup behavior before Control Room v2 behavior changes. Outcome: approved path; behavior changes may proceed behind feature flag Evidence: - Highest-risk conflict: `app.py` inline WAT dispatch path (`_dispatch_workflow_action_inline`, `api_workflow_action`) reassigns/forces todo and injects/spawns runtime. - Comment route conflict: `api_add_comment` + `_route_human_comment` can reopen/requeue/spawn runtimes. - Telegram has direct runtime-send paths plus comment API path, so MC comment route must change too in later slice. - Board currently uses internal statuses/filters; do not collapse DB statuses first. Recommended first behavior-changing slice: - Add default-off flag `MC_CONTROL_ROOM_V2_CONTROLLER_NOTIFY`. - Under the flag, dispatch workflow actions (`send_to_larry`, `send_to_tessa`, `send_to_council`, `return_for_fixes`, etc.) should persist a Controller notification/audit comment and return `queued_for_controller=true`. - Under the flag, they must not call `_dispatch_workflow_action_inline`, not call `_queue_and_pickup`, not reassign, and not force `todo`. - State-only actions like approve/close remain unchanged initially. Next step: Coder slice for feature-flag WAT dispatch notification behavior.