Luci · Read the WIP files + current diff to understand state
Luci
Read the WIP files + current diff to understand state.
Luci
WIP has chip restyle, mobile media queries, filter toggle, safe-area. Missing: **filter reset control** + default-usable behavior. Read full board_v2.html to understand filter state + persistence.
Luci
Filter values are server-driven (`current_sort`, `current_project`). Need to find board route in app.py to understand persistence ("board remembers prior filters, can't reset").
Luci
The rtk grep output is mangled. Read the route block directly.
Luci
Now read `_board_context` — does it read filters from query args, session, or cookie? This is the persistence root cause.
Luci
Filters come purely from query string — no server session persistence. The "remembering" must be client-side localStorage. Search base/board templates + static JS.
Luci
Check base.html for nav links that might carry query state to /board, plus bottom-nav structure (overlap concern).
Luci
Found it — base.html rewrites the Board nav link via `window.boardUrl()` to "preserve saved filters". Read that block + find `boardUrl`.
Luci
Read the top of this IIFE to see FILTER_KEY + the auto-redirect logic.
Luci
Root cause confirmed: **MC-57 persistent filters** (`static/app.js:35-58`) — saves filter params to `sessionStorage.mc_board_filters` and auto-redirects plain `/board` → `/board?<saved>`. No way to clear. That's the "can't reset" bug.
Now check ticket-detail wrapping fix (#2) + MC running state + tester instructions location. Parallel.
Luci
MC active, V2 enabled. Find existing tester/QA instructions + gates in repo (req C).
Luci
Rich context. Read the QA gate enforcement (`mc_tessa_gate.py`) + existing mc4591 report to see what prior WIP claimed.
Luci
Gate is robust — already requires real 375px screenshot + width==375 + explicit verdict (kills fake desktop approval). Need to extend `_MOBILE_CONTRADICTION_PATTERNS` for new failure modes. First verify the ticket-detail one-char-wrap fix so I don't break it.
Luci
Ticket-detail fix present (`overflow-wrap:anywhere` + `min-width:0` on flex containers, lines 14/143/257). Won't touch ticket.html — verify via screenshot only.
Now implement. Start with **board_v2.html filter reset**. Add CSS for clear button + active indicator.
Luci
Add mobile sizing for clear button in the media queries.
Luci
Now add the Clear button to the filter-row HTML + the dot on the toggle.
Luci
Now the JS: `v2ClearFilters()` + active-filter detection on load.
Luci
Refine `v2RefreshFilterState` to also detect active state from the live select/search values (so changing project via the select lights up Clear), and call it from `v2Reload`.
Luci
Now hook `v2RefreshFilterState` into `v2Reload` and `v2ClientSearch` so Clear lights up live.
Luci
board_v2 filter reset done. Now harden the QA gate. Extend `_MOBILE_CONTRADICTION_PATTERNS` with the new mandatory failure modes.
Luci
Now update the Tessa dispatch comment so testers get the explicit mobile-failure checklist.
Luci
Now the durable tester checklist doc.
Luci
Now write tests for the hardened gate. Check existing test conventions first.
Luci
Write a focused test for the hardened gate patterns.
Luci
Now run the tests — new gate test + existing gate test + board_v2 test.
Luci
subTest hides siblings. Find ALL non-matching phrases directly.
Luci
Three phrases have reversed word order. Fix patterns.
Luci
All green — but verify the count didn't silently drop my new file. Run explicit.
Luci
All tests pass (exit 0). JS additions are plain (no Jinja). Now screenshots at 375px — but live gunicorn caches templates. Spin an **isolated** dev instance on a throwaway port (won't touch live :3001), screenshot, kill. Check app entrypoint.
Luci
Launch an isolated dev instance on port 3099 with a **copy** of mc.db (eval-isolation: never touch live board). Then screenshot at 375px.
Luci
Preview up (200). Screenshot at 375px via browser-harness with mobile device-metrics override.
Luci
Current binary needs `-c`. Write script to file, exec it.
Luci
`cdp()` takes kwargs, not a dict (2nd positional is `session_id`). Fix the script.
Luci
Screenshots captured, `pw=375` on both (no horizontal overflow — good sign). Now do the **real visual QA** — view them. Read board top + filters-open + ticket.
Luci
Real QA finding: the **"Start" quick-action button renders as a near-black box with barely-legible text on the white (light-theme) card** — a low-contrast/broken-looking button, exactly the defect class flagged. Check other shots first.
Luci
Now two clear defects in **light theme**:
1. The sort/project selects + search render as **black boxes with near-invisible text** — low-contrast failure.
2. The **Clear button didn't appear** (gated on `has-active-filter`, and default board has none). Need it discoverable when filters are open.
Check how `--surface-2`/`--text` resolve in light theme.
Luci
**Root cause found.** Theme defines `--surface2` (no hyphen) but board_v2 uses `var(--surface-2, #1a1a1a)` (hyphen) — an **undefined variable**, so it always falls back to dark `#1a1a1a`. In light theme that's a black box; `--text` resolves to dark → near-invisible text. This is the core "disaster on phone" bug. Check scope.
Luci
Theme has `--surface2`/`--surface` but no `--surface3`; board_v2 uses the typo'd `--surface-2`/`--surface-3`. Fix the in-scope board_v2 templates to use correct theme-aware var names (surgical — no global blast radius).
Luci
Now the card template — qa-btn background/hover use the typo'd vars.
Luci
Colored button/chip text uses 400-level colors tuned for dark theme. Need to confirm which theme the user actually sees. Also: Flask dev server caches templates — must restart preview to pick up my edits. Check theme mechanism + restart.
Luci
Theme is `auto` (prefers-color-scheme); harness Chrome resolved to **light**, which exposed the black-box bug. Must support both themes. Restart preview to load template edits, then re-shoot light + dark.
Luci
Relaunch persistently with `run_in_background`.
Luci
`pkill -f "app.py --port 3099"` matched its own launcher command line → self-kill (exit 144). Avoid pkill. Check port, launch detached without self-matching kill.
Luci
Port free. Launch detached via setsid (background task), no pkill.
Luci
Up (200). Re-shoot both themes. Set theme via localStorage before load.
Luci
All shot. Review: light top (was the broken one), light filters+Clear, dark top, ticket.
Luci
Light theme **fixed** — no more black boxes, Start buttons legible, chips clear, no overflow. Check the Clear control + selects.
Luci
Clear control + active-dot work perfectly in light. Verify dark theme (no regression) + ticket detail (one-char fix intact).
Luci
Dark theme clean — no regression, Clear + dot work. Now ticket detail (one-char-wrap regression guard).
Luci
Ticket detail: title wraps as **words, multi-line — no one-char-per-line collapse**. Fix intact. Check bottom (nav overlap on load-more).
Luci
Remaining defect: **"Load more…" is a black box in light theme** (same `--surface-2` typo, in panel template I haven't fixed). Bottom-nav spacing is good (no overlap). Fix the panel.
Luci
Verify no `--surface-2`/`--surface-3` typos remain in board_v2 files.
Luci
Restart preview (panel edit) + re-shoot the canonical report set.
Luci
Confirm Load-more fix in light bottom.
Luci
"Load more…" fixed — legible, no nav overlap. **All visual defects resolved in both themes.** Now final test pass + generate diff for council review.
Luci
99 passed, exit 0. Dispatch a Claude subagent code reviewer (council gate — no GLM per constraint) on the diff, in background, while I write the report.
Luci
Reviewer running. Write the report while it works.
Luci
Old report was a FAIL gate flagging exactly the low-contrast bug I fixed — good corroboration. Overwrite with the new report.
Luci
Reviewer returned. Triage:
- **#1 (/board destination):** verified non-issue — `/board` route serves v2 when `MC_BOARD_V2_ENABLED=1` (live flag on). Correct canonical URL.
- **#3 (parse-time DOM):** non-issue — `.v2-board-shell` is server-rendered inline in board_v2.html *above* the script (full page, not htmx-swapped). Shell exists when script runs; null-guard covers edge.
- **#2 (negation false-positives):** VALID — a clean report saying "no low-contrast issues" would wrongly hard-fail. Fix with negation guard.
- **#4 (Clear <44px):** VALID — my own gate enforces 44px. Bump.
- **#5 (CTA title attr dropped):** check + restore.
Fix #2 — add negation guard in `_mobile_contradictions`.
Luci
Add negation test. Read the test file region to extend.
Luci
Now #4 — bump mobile Clear + expanded controls to 44px touch targets.
Luci
#5 — check CTA chip for dropped title attr.
Luci
Add the missing `title` to the CTA chip (consistency + a11y).
Luci
Re-run tests (incl. new negation test) + compile.
Luci
98 passed, exit 0, negation test green. Restart preview + re-shoot filters view to confirm 44px Clear.
Luci
Clear button measures 44px. Quick visual confirm.
Luci
Clean — 44px Clear, full-width, legible, dot present. Append council results to report + clean up preview.
Luci
All complete. Preview stopped, temp DB removed, tests green. Final pane message:
---
REVIEW_READY: MC-4591 Board v2 mobile UX + filter reset + QA-gate hardening. Not committed/pushed (per instruction).
**Root causes fixed**
- Light-theme "black boxes": board_v2 used undefined `var(--surface-2)`/`--surface-3` (theme defines `--surface2`/`--surface`) → always fell back to dark `#1a1a1a`. Swapped to correct theme vars. This was the core "disaster on phone" bug.
- "Can't reset filters": `static/app.js` (MC-57) saves filters to `sessionStorage.mc_board_filters` and auto-redirects `/board`→`/board?<saved>`. Added obvious **Clear** control + active dot; `v2ClearFilters()` wipes that key and hard-navigates clean `/board`, breaking the trap.
**Changed files**
- `templates/board_v2.html` — surface-var fix; Clear button + active-filter dot; `v2ClearFilters()`/`v2RefreshFilterState()`; 44px mobile touch targets.
- `templates/partials/board_v2_card.html` — surface-var fix; restored CTA chip `title`.
- `templates/partials/board_v2_panel.html` — load-more surface-var fix.
- `mc_tessa_gate.py` — `_MOBILE_CONTRADICTION_PATTERNS` hard-fails reports describing one-char wrap / horizontal overflow / cramped toolbar / low-contrast / bottom-nav overlap / stale-filter-no-reset / sub-44px; negation guard (`_is_negated`) prevents false-fails on clean reports; expanded dispatch instruction comment.
- `docs/mobile-qa-checklist.md` (new) — canonical 375px tester contract.
- `tests/test_mc4591_mobile_gate.py` (new) — 5 tests.
- `static/style.css` — **pre-existing WIP from prior session, NOT touched by me.**
**Tests:** `pytest tests/test_mc4591_mobile_gate.py tests/test_mc4303_tessa_gate.py tests/test_board_v2.py` → all pass, exit 0. `mc_tessa_gate.py` compiles.
**Screenshots (real 375px viewport, both themes)** in `dogfood-output/mc4591/`:
- `board_375_light_top.png`, `board_375_light_filters_clear.png`, `board_375_light_bottom.png`
- `board_375_dark_top.png`, `board_375_dark_filters_clear.png`, `board_375_dark_bottom.png`
- `ticket4591_375_dark_top.png` — title wraps as words, **no one-char-per-line collapse** (req 2 intact)
- `report.md` — full report. `pw==375` on every shot → no horizontal overflow. Clear button measured 44px.
**QA done strict + visual** (I viewed every screenshot): black boxes gone, controls/chips/buttons legible both themes, Clear+dot work, load-more clears bottom nav, no overflow. Captured against **isolated** preview (port 3099, copy of mc.db) — live MC on :3001 never touched; preview stopped + temp DB removed.
**Council** (Claude code-reviewer subagent — no GLM/ZAI per constraint): no CRITICAL. Actioned its 3 valid findings (gate false-positives → negation guard; <44px Clear → 44px; dropped CTA title → restored). 2 flagged items verified as non-issues.
**Blockers:** none.